kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-04-30 00:33:09 +00:00
Code Issues Releases Wiki Activity

Fix some warnings with clang static analyzer

Browse source 
Only one remains (also in tbprobe.cpp), but is bougus.

As a side note, tbprobe.cpp is almost clean, only the last 3
functions probe_wdl(), root_probe() and root_probe_wdl()
are still the original ones and are quite hacky.

Somewhere in the future we will reformat also the last 3
ones. The reason why has not been done before it is because
these functions are really wrong by design and should be
rewritten entirely, not only reformatted.

No functional change.

Closes #1160
This commit is contained in:
Marco Costalba 2017-07-02 13:39:58 +02:00 • committed by Joona Kiiski
parent c0cb713a00
commit 01b6cdb76b
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/syzygy/tbprobe.cpp
View file

@ -713,8 +713,9 @@ T do_probe_table(const Position& pos, Entry* entry, WDLScore wdl, ProbeState* re
assert(type_of(pc) == PAWN); assert(type_of(pc) == PAWN);
leadPawns = b = pos.pieces(color_of(pc), PAWN); leadPawns = b = pos.pieces(color_of(pc), PAWN);
while (b) do
squares[size++] = pop_lsb(&b) ^ flipSquares; squares[size++] = pop_lsb(&b) ^ flipSquares;
while (b);
leadPawnsCnt = size; leadPawnsCnt = size;
@ -737,11 +738,13 @@ T do_probe_table(const Position& pos, Entry* entry, WDLScore wdl, ProbeState* re
// Now we are ready to get all the position pieces (but the lead pawns) and // Now we are ready to get all the position pieces (but the lead pawns) and
// directly map them to the correct color and square. // directly map them to the correct color and square.
b = pos.pieces() ^ leadPawns; b = pos.pieces() ^ leadPawns;
while (b) { do {
Square s = pop_lsb(&b); Square s = pop_lsb(&b);
squares[size] = s ^ flipSquares; squares[size] = s ^ flipSquares;
pieces[size++] = Piece(pos.piece_on(s) ^ flipColor); pieces[size++] = Piece(pos.piece_on(s) ^ flipColor);
} } while (b);
assert(size >= 2);
// Then we reorder the pieces to have the same sequence as the one stored // Then we reorder the pieces to have the same sequence as the one stored
// in precomp->pieces[i]: the sequence that ensures the best compression. // in precomp->pieces[i]: the sequence that ensures the best compression.
@ -1517,6 +1520,8 @@ static int has_repeated(StateInfo *st)
// no moves were filtered out. // no moves were filtered out.
bool Tablebases::root_probe(Position& pos, Search::RootMoves& rootMoves, Value& score) bool Tablebases::root_probe(Position& pos, Search::RootMoves& rootMoves, Value& score)
{ {
assert(rootMoves.size());
ProbeState result; ProbeState result;
int dtz = probe_dtz(pos, &result); int dtz = probe_dtz(pos, &result);
@ -1562,7 +1567,7 @@ bool Tablebases::root_probe(Position& pos, Search::RootMoves& rootMoves, Value&
// Obtain 50-move counter for the root position. // Obtain 50-move counter for the root position.
// In Stockfish there seems to be no clean way, so we do it like this: // In Stockfish there seems to be no clean way, so we do it like this:
int cnt50 = st.previous->rule50; int cnt50 = st.previous ? st.previous->rule50 : 0;
// Use 50-move counter to determine whether the root position is // Use 50-move counter to determine whether the root position is
// won, lost or drawn. // won, lost or drawn.