kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-07-11 19:49:14 +00:00
Code Issues Releases Wiki Activity

Fix another setting of a flag out of lock protection

Browse source 
In this case is dangerous because in split() we reset the flag to
false, but if it was set due to a cut-off higher in the tree we
completely miss that and go on with the full search.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba 2010-02-14 16:29:28 +01:00
parent b29198354c
commit 0895f1ac71
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/search.cpp
View file

@ -2904,10 +2904,16 @@ namespace {
for (int i = 0; i < ActiveThreads; i++)
splitPoint->slaves[i] = 0;
threads[master].idle = false;
threads[master].stopRequest = false;
threads[master].splitPoint = splitPoint;
// If we are here it means we are not idle
assert(!threads[master].idle);
// Following assert could fail because we could be slave of a master
// thread that has just raised a stop request. Note that stopRequest
// can be changed with only splitPoint::lock held, not with MPLock.
/* assert(!threads[master].stopRequest); */
// Allocate available threads setting idle flag to false
for (int i = 0; i < ActiveThreads && splitPoint->cpus < MaxThreadsPerSplitPoint; i++)
if (thread_is_available(i, master))