kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-07-12 03:59:15 +00:00
Code Issues Releases Wiki Activity

Fix again early stop ss pointer

Browse source 
Fix was wrong becuase search starts from ss+1,
code is a bit tricky here, so rewrite in a way
to be more easy to read and understand.

Spotted by Eelco.

No functional change.
This commit is contained in:
Marco Costalba 2013-06-09 23:32:12 +02:00
parent de1dc4f2de
commit 1b7223a53c
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/search.cpp
View file

@ -295,14 +295,14 @@ namespace {
void id_loop(Position& pos) { void id_loop(Position& pos) {
Stack ss[MAX_PLY_PLUS_2]; Stack stack[MAX_PLY_PLUS_2], *ss = stack+1; // To allow referencing (ss-1)
int depth, prevBestMoveChanges; int depth, prevBestMoveChanges;
Value bestValue, alpha, beta, delta; Value bestValue, alpha, beta, delta;
memset(ss, 0, 4 * sizeof(Stack)); memset(ss-1, 0, 4 * sizeof(Stack));
depth = BestMoveChanges = 0; depth = BestMoveChanges = 0;
bestValue = delta = -VALUE_INFINITE; bestValue = delta = -VALUE_INFINITE;
ss->currentMove = MOVE_NULL; // Hack to skip update gains (ss-1)->currentMove = MOVE_NULL; // Hack to skip update gains
TT.new_search(); TT.new_search();
History.clear(); History.clear();
Gains.clear(); Gains.clear();
@ -349,9 +349,7 @@ namespace {
// research with bigger window until not failing high/low anymore. // research with bigger window until not failing high/low anymore.
while (true) while (true)
{ {
// Search starts from ss+1 to allow referencing (ss-1). This is bestValue = search<Root>(pos, ss, alpha, beta, depth * ONE_PLY);
// needed by update gains and ss copy when splitting at Root.
bestValue = search<Root>(pos, ss+1, alpha, beta, depth * ONE_PLY);
// Bring to front the best move. It is critical that sorting is // Bring to front the best move. It is critical that sorting is
// done with a stable algorithm because all the values but the first // done with a stable algorithm because all the values but the first
@ -1693,11 +1691,11 @@ void Thread::idle_loop() {
Threads.mutex.unlock(); Threads.mutex.unlock();
Stack ss[MAX_PLY_PLUS_2]; Stack stack[MAX_PLY_PLUS_2], *ss = stack+1; // To allow referencing (ss-1)
Position pos(*sp->pos, this); Position pos(*sp->pos, this);
memcpy(ss, sp->ss - 1, 4 * sizeof(Stack)); memcpy(ss-1, sp->ss-1, 4 * sizeof(Stack));
(ss+1)->splitPoint = sp; ss->splitPoint = sp;
sp->mutex.lock(); sp->mutex.lock();
@ -1707,13 +1705,13 @@ void Thread::idle_loop() {
switch (sp->nodeType) { switch (sp->nodeType) {
case Root: case Root:
search<SplitPointRoot>(pos, ss+1, sp->alpha, sp->beta, sp->depth); search<SplitPointRoot>(pos, ss, sp->alpha, sp->beta, sp->depth);
break; break;
case PV: case PV:
search<SplitPointPV>(pos, ss+1, sp->alpha, sp->beta, sp->depth); search<SplitPointPV>(pos, ss, sp->alpha, sp->beta, sp->depth);
break; break;
case NonPV: case NonPV:
search<SplitPointNonPV>(pos, ss+1, sp->alpha, sp->beta, sp->depth); search<SplitPointNonPV>(pos, ss, sp->alpha, sp->beta, sp->depth);
break; break;
default: default:
assert(false); assert(false);