kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-04-30 08:43:09 +00:00
Code Issues Releases Wiki Activity

Add a comment and a FIXME

Browse source 
And fix indentation too.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba 2010-05-08 13:30:34 +01:00
parent 276513c19f
commit 35e39a196d
1 changed files with 31 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
src/search.cpp
View file

@ -1247,9 +1247,10 @@ namespace {
if (abs(ttValue) < VALUE_KNOWN_WIN) if (abs(ttValue) < VALUE_KNOWN_WIN)
{ {
Value excValue = search<NonPV>(pos, ss, ttValue - SingularExtensionMargin - 1, ttValue - SingularExtensionMargin, depth / 2, ply, false, threadID, move); Value b = ttValue - SingularExtensionMargin;
Value v = search<NonPV>(pos, ss, b - 1, b, depth / 2, ply, false, threadID, move);
if (excValue < ttValue - SingularExtensionMargin) if (v < ttValue - SingularExtensionMargin)
ext = OnePly; ext = OnePly;
} }
} }
@ -1274,7 +1275,7 @@ namespace {
continue; continue;
// Value based pruning // Value based pruning
Depth predictedDepth = newDepth - reduction<NonPV>(depth, moveCount); // We illogically ignore reduction condition depth >= 3*OnePly Depth predictedDepth = newDepth - reduction<NonPV>(depth, moveCount); // FIXME We illogically ignore reduction condition depth >= 3*OnePly
futilityValueScaled = ss[ply].eval + futility_margin(predictedDepth, moveCount) futilityValueScaled = ss[ply].eval + futility_margin(predictedDepth, moveCount)
+ H.gain(pos.piece_on(move_from(move)), move_to(move)); + H.gain(pos.piece_on(move_from(move)), move_to(move));
@ -1295,34 +1296,36 @@ namespace {
value = -search<PV>(pos, ss, -beta, -alpha, newDepth, ply+1, false, threadID); value = -search<PV>(pos, ss, -beta, -alpha, newDepth, ply+1, false, threadID);
else else
{ {
// Step 14. Reduced search // Step 14. Reduced search
// if the move fails high will be re-searched at full depth. // if the move fails high will be re-searched at full depth.
bool doFullDepthSearch = true; bool doFullDepthSearch = true;
if ( depth >= 3 * OnePly if ( depth >= 3 * OnePly
&& !dangerous && !dangerous
&& !captureOrPromotion && !captureOrPromotion
&& !move_is_castle(move) && !move_is_castle(move)
&& !move_is_killer(move, ss[ply])) && !move_is_killer(move, ss[ply]))
{ {
ss[ply].reduction = reduction<PvNode>(depth, moveCount); ss[ply].reduction = reduction<PvNode>(depth, moveCount);
if (ss[ply].reduction) if (ss[ply].reduction)
{ {
value = -search<NonPV>(pos, ss, -(alpha+1), -alpha, newDepth-ss[ply].reduction, ply+1, true, threadID); value = -search<NonPV>(pos, ss, -(alpha+1), -alpha, newDepth-ss[ply].reduction, ply+1, true, threadID);
doFullDepthSearch = (value > alpha); doFullDepthSearch = (value > alpha);
} }
} }
// Step 15. Full depth search // Step 15. Full depth search
if (doFullDepthSearch) if (doFullDepthSearch)
{ {
ss[ply].reduction = Depth(0); ss[ply].reduction = Depth(0);
value = -search<NonPV>(pos, ss, -(alpha+1), -alpha, newDepth, ply+1, true, threadID); value = -search<NonPV>(pos, ss, -(alpha+1), -alpha, newDepth, ply+1, true, threadID);
// Step extra. pv search (only in PV nodes) // Step extra. pv search (only in PV nodes)
if (PvNode && value > alpha && value < beta) // Search only for possible new PV nodes, if instead value >= beta then
value = -search<PV>(pos, ss, -beta, -alpha, newDepth, ply+1, false, threadID); // parent node fails low with value <= alpha and tries another move.
} if (PvNode && value > alpha && value < beta)
value = -search<PV>(pos, ss, -beta, -alpha, newDepth, ply+1, false, threadID);
}
} }
// Step 16. Undo move // Step 16. Undo move