kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-04-30 00:33:09 +00:00
Code Issues Releases Wiki Activity

Fix a possible crash in excluded search condition

Browse source 
Due to IID we could have a ttMove and not a tte, or,
even if we have a tte they could belong to different
searches so that the depth and type of tte don't
have the same origin of the ttMove.

To fix this we always use tte entry in excluded search
condition and, after an IID, we reprobe the TT table.

No functional change. Apart from possible crash fix.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba 2009-11-26 13:44:48 +01:00
parent 6ae30e7cb1
commit 5bec768d42
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/search.cpp
View file

@ -1137,6 +1137,11 @@ namespace {
{
search_pv(pos, ss, alpha, beta, depth-2*OnePly, ply, threadID);
ttMove = ss[ply].pv[ply];
tte = TT.retrieve(pos.get_key());
// Following assert could fail, for instance when we have
// moveCount == 0 we return without saving a TT entry.
/* assert(tte); */
}
// Initialize a MovePicker object for the current position, and prepare
@ -1165,8 +1170,11 @@ namespace {
// To verify this we do a reduced search on all the other moves but the ttMove,
// if result is lower then TT value minus a margin then we assume ttMove is the
// only one playable. It is a kind of relaxed single reply extension.
// Note that could be ttMove != tte->move() due to IID, so we always use tte->move()
// to avoid aliases when we probe tte->depth() and tte->type()
if ( depth >= 8 * OnePly
&& move == ttMove
&& tte
&& move == tte->move()
&& ext < OnePly
&& is_lower_bound(tte->type())
&& tte->depth() >= depth - 3 * OnePly)
@ -1430,6 +1438,7 @@ namespace {
{
search(pos, ss, beta, Min(depth/2, depth-2*OnePly), ply, false, threadID);
ttMove = ss[ply].pv[ply];
tte = TT.retrieve(pos.get_key());
}
// Initialize a MovePicker object for the current position, and prepare
@ -1467,9 +1476,12 @@ namespace {
// To verify this we do a reduced search on all the other moves but the ttMove,
// if result is lower then TT value minus a margin then we assume ttMove is the
// only one playable. It is a kind of relaxed single reply extension.
// Note that could be ttMove != tte->move() due to IID, so we always use tte->move()
// to avoid aliases when we probe tte->depth() and tte->type()
if ( depth >= 8 * OnePly
&& !excludedMove // do not allow recursive single-reply search
&& move == ttMove
&& tte
&& move == tte->move()
&& !excludedMove // Do not allow recursive single-reply search
&& ext < OnePly
&& is_lower_bound(tte->type())
&& tte->depth() >= depth - 3 * OnePly)