diff --git a/src/search.cpp b/src/search.cpp index e521b868..d022b3de 100644 --- a/src/search.cpp +++ b/src/search.cpp @@ -2212,6 +2212,9 @@ split_point_start: // At split points actual search starts from here assert(threadID >= 0 && threadID < MAX_THREADS); + int i; + bool allFinished = false; + while (true) { // Slave threads can exit as soon as AllThreadsShouldExit raises, @@ -2227,23 +2230,23 @@ split_point_start: // At split points actual search starts from here // instead of wasting CPU time polling for work. while ( threadID >= ActiveThreads || threads[threadID].state == THREAD_INITIALIZING - || (!sp && threads[threadID].state == THREAD_AVAILABLE)) + || threads[threadID].state == THREAD_AVAILABLE) { - assert(!sp); - assert(threadID != 0); - - if (AllThreadsShouldExit) - break; - lock_grab(&MPLock); - // Retest condition under lock protection - if (!( threadID >= ActiveThreads - || threads[threadID].state == THREAD_INITIALIZING - || (!sp && threads[threadID].state == THREAD_AVAILABLE))) + // Test with lock held to avoid races with wake_sleeping_thread() + for (i = 0; sp && i < ActiveThreads && !sp->slaves[i]; i++) {} + allFinished = (i == ActiveThreads); + + // Retest sleep conditions under lock protection + if ( AllThreadsShouldExit + || allFinished + || !( threadID >= ActiveThreads + || threads[threadID].state == THREAD_INITIALIZING + || threads[threadID].state == THREAD_AVAILABLE)) { lock_release(&MPLock); - continue; + break; } // Put thread to sleep @@ -2273,14 +2276,19 @@ split_point_start: // At split points actual search starts from here assert(threads[threadID].state == THREAD_SEARCHING); threads[threadID].state = THREAD_AVAILABLE; + + // Wake up master thread so to allow it to return from the idle loop in + // case we are the last slave of the split point. + if (threadID != tsp->master && threads[tsp->master].state == THREAD_AVAILABLE) + wake_sleeping_thread(tsp->master); } // If this thread is the master of a split point and all slaves have // finished their work at this split point, return from the idle loop. - int i = 0; - for ( ; sp && i < ActiveThreads && !sp->slaves[i]; i++) {} + for (i = 0; sp && i < ActiveThreads && !sp->slaves[i]; i++) {} + allFinished = (i == ActiveThreads); - if (i == ActiveThreads) + if (allFinished) { // Because sp->slaves[] is reset under lock protection, // be sure sp->lock has been released before to return. @@ -2487,6 +2495,7 @@ split_point_start: // At split points actual search starts from here // Initialize the split point object splitPoint.parent = masterThread.splitPoint; + splitPoint.master = master; splitPoint.stopRequest = false; splitPoint.ply = ply; splitPoint.depth = depth; diff --git a/src/thread.h b/src/thread.h index 372d4da3..965bd30b 100644 --- a/src/thread.h +++ b/src/thread.h @@ -55,6 +55,7 @@ struct SplitPoint { bool pvNode, mateThreat; Value beta; int ply; + int master; Move threatMove; SearchStack sstack[MAX_THREADS][PLY_MAX_PLUS_2];