Fix some Intel compilers warnings

Also a compile fix due to Makefile missing new
application.cpp file.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>

src/Makefile

@@ -24,7 +24,7 @@
 
 EXE = stockfish
 
-OBJS = bitboard.o pawns.o material.o endgame.o evaluate.o main.o \
+OBJS = application.o bitboard.o pawns.o material.o endgame.o evaluate.o main.o \
 	misc.o move.o movegen.o history.o movepick.o search.o piece.o \
 	position.o direction.o tt.o value.o uci.o ucioption.o \
 	mersenne.o book.o bitbase.o san.o benchmark.o

src/evaluate.cpp

@@ -571,10 +571,9 @@ namespace {
     ei.egMobility += Sign[us] * EgBonus[Piece][mob];
 
     // Bishop and Knight outposts
-    if (  (Piece != BISHOP && Piece != KNIGHT) // compile time condition
+    if (   (Piece == BISHOP || Piece == KNIGHT) // compile time condition
-        || !p.square_is_weak(s, them))
+        && p.square_is_weak(s, them))
-        return mob;
+    {
-
         // Initial bonus based on square
         Value v, bonus;
         v = bonus = OutpostBonus[Piece][relative_square(us, s)];
@@ -590,6 +589,7 @@ namespace {
         }
         ei.mgValue += Sign[us] * bonus;
         ei.egValue += Sign[us] * bonus;
+    }
     return mob;
   }
 

src/movegen.cpp

@@ -835,9 +835,8 @@ namespace {
 
     // Direct checks
     b = target & ~dc;
-    if (Piece == KING || !b)
+    if (Piece != KING || b)
-        return mlist;
+    {
-
         Bitboard checkSqs = pos.piece_attacks<Piece>(ksq) & pos.empty_squares();
         if (!checkSqs)
             return mlist;
@@ -853,6 +852,7 @@ namespace {
             Bitboard bb = pos.piece_attacks<Piece>(from) & checkSqs;
             SERIALIZE_MOVES(bb);
         }
+    }
     return mlist;
   }
 

src/movepick.h

@@ -37,6 +37,8 @@
 struct EvalInfo;
 struct SearchStack;
 
+extern SearchStack EmptySearchStack;
+
 /// MovePicker is a class which is used to pick one legal move at a time from
 /// the current position.  It is initialized with a Position object and a few
 /// moves we have reason to believe are good.  The most important method is

src/position.cpp

@@ -40,8 +40,6 @@
 //// Variables
 ////
 
-extern SearchStack EmptySearchStack;
-
 int Position::castleRightsMask[64];
 
 Key Position::zobrist[2][8][64];

src/san.cpp

@@ -31,7 +31,6 @@
 #include "movepick.h"
 #include "san.h"
 
-extern SearchStack EmptySearchStack;
 
 ////
 //// Local definitions