1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-04-30 08:43:09 +00:00

Make posix and msys2 shells consistent in CI

In CI, it is typical for the process to halt immediately when an error
is encountered. However, with our `shell: bash {0}` configuration,
the process continues despite errors for posix shells.
This commit updates the behavior of posix and msys2 shells to ensure
consistency in terms of pipeline exit codes and stop conditions.
We adopt the most appropriate default behavior as recommended
by the GitHub documentation.

Update the code that searches for the bench value in the git log:
- to be compatible with the new shell settings
- to retry the value from the first line that contains
  only the template and spaces/tabs/newlines

see also

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
https://github.com/msys2/setup-msys2/blob/main/main.js

closes https://github.com/official-stockfish/Stockfish/pull/4653

No functional change
This commit is contained in:
ppigazzini 2023-07-01 14:36:52 +02:00 committed by Joost VandeVondele
parent 915532181f
commit 9a2d50eccc
5 changed files with 17 additions and 17 deletions

View file

@ -20,13 +20,13 @@ jobs:
compiler: aarch64-linux-android21-clang++ compiler: aarch64-linux-android21-clang++
emu: qemu-aarch64 emu: qemu-aarch64
comp: ndk comp: ndk
shell: bash {0} shell: bash
- name: Android NDK arm - name: Android NDK arm
os: ubuntu-22.04 os: ubuntu-22.04
compiler: armv7a-linux-androideabi21-clang++ compiler: armv7a-linux-androideabi21-clang++
emu: qemu-arm emu: qemu-arm
comp: ndk comp: ndk
shell: bash {0} shell: bash
binaries: binaries:
- armv8 - armv8
- armv7 - armv7

View file

@ -19,14 +19,14 @@ jobs:
simple_name: ubuntu simple_name: ubuntu
compiler: g++ compiler: g++
comp: gcc comp: gcc
shell: bash {0} shell: bash
archive_ext: tar archive_ext: tar
- name: MacOS 12 Apple Clang - name: MacOS 12 Apple Clang
os: macos-12 os: macos-12
simple_name: macos simple_name: macos
compiler: clang++ compiler: clang++
comp: clang comp: clang
shell: bash {0} shell: bash
archive_ext: tar archive_ext: tar
- name: Windows 2022 Mingw-w64 GCC x86_64 - name: Windows 2022 Mingw-w64 GCC x86_64
os: windows-2022 os: windows-2022

View file

@ -15,22 +15,22 @@ jobs:
os: ubuntu-20.04 os: ubuntu-20.04
compiler: g++ compiler: g++
comp: gcc comp: gcc
shell: bash {0} shell: bash
- name: Ubuntu 20.04 Clang - name: Ubuntu 20.04 Clang
os: ubuntu-20.04 os: ubuntu-20.04
compiler: clang++ compiler: clang++
comp: clang comp: clang
shell: bash {0} shell: bash
- name: MacOS 12 Apple Clang - name: MacOS 12 Apple Clang
os: macos-12 os: macos-12
compiler: clang++ compiler: clang++
comp: clang comp: clang
shell: bash {0} shell: bash
- name: MacOS 12 GCC 11 - name: MacOS 12 GCC 11
os: macos-12 os: macos-12
compiler: g++-11 compiler: g++-11
comp: gcc comp: gcc
shell: bash {0} shell: bash
- name: Windows 2022 Mingw-w64 GCC x86_64 - name: Windows 2022 Mingw-w64 GCC x86_64
os: windows-2022 os: windows-2022
compiler: g++ compiler: g++

View file

@ -16,7 +16,7 @@ jobs:
os: ubuntu-20.04 os: ubuntu-20.04
compiler: g++ compiler: g++
comp: gcc comp: gcc
shell: bash {0} shell: bash
sanitizers: sanitizers:
- name: Run with thread sanitizer - name: Run with thread sanitizer
make_option: sanitize=thread make_option: sanitize=thread

View file

@ -18,38 +18,38 @@ jobs:
comp: gcc comp: gcc
run_32bit_tests: true run_32bit_tests: true
run_64bit_tests: true run_64bit_tests: true
shell: bash {0} shell: bash
- name: Ubuntu 20.04 Clang - name: Ubuntu 20.04 Clang
os: ubuntu-20.04 os: ubuntu-20.04
compiler: clang++ compiler: clang++
comp: clang comp: clang
run_32bit_tests: true run_32bit_tests: true
run_64bit_tests: true run_64bit_tests: true
shell: bash {0} shell: bash
- name: Android NDK aarch64 - name: Android NDK aarch64
os: ubuntu-22.04 os: ubuntu-22.04
compiler: aarch64-linux-android21-clang++ compiler: aarch64-linux-android21-clang++
comp: ndk comp: ndk
run_armv8_tests: true run_armv8_tests: true
shell: bash {0} shell: bash
- name: Android NDK arm - name: Android NDK arm
os: ubuntu-22.04 os: ubuntu-22.04
compiler: armv7a-linux-androideabi21-clang++ compiler: armv7a-linux-androideabi21-clang++
comp: ndk comp: ndk
run_armv7_tests: true run_armv7_tests: true
shell: bash {0} shell: bash
- name: MacOS 12 Apple Clang - name: MacOS 12 Apple Clang
os: macos-12 os: macos-12
compiler: clang++ compiler: clang++
comp: clang comp: clang
run_64bit_tests: true run_64bit_tests: true
shell: bash {0} shell: bash
- name: MacOS 12 GCC 11 - name: MacOS 12 GCC 11
os: macos-12 os: macos-12
compiler: g++-11 compiler: g++-11
comp: gcc comp: gcc
run_64bit_tests: true run_64bit_tests: true
shell: bash {0} shell: bash
- name: Windows 2022 Mingw-w64 GCC x86_64 - name: Windows 2022 Mingw-w64 GCC x86_64
os: windows-2022 os: windows-2022
compiler: g++ compiler: g++
@ -115,8 +115,8 @@ jobs:
- name: Extract the bench number from the commit history - name: Extract the bench number from the commit history
run: | run: |
git log HEAD | grep -o "\b[Bb]ench[ :]\+[1-9][0-9]\{5,9\}\b" | head -n 1 | sed "s/[^0-9]//g" > git_sig benchref=$(git log HEAD | grep -m 1 -o -x "[[:space:]]*\b[Bb]ench[ :]\+[1-9][0-9]\{5,7\}\b[[:space:]]*" | sed "s/[^0-9]//g") || true
[ -s git_sig ] && echo "benchref=$(cat git_sig)" >> $GITHUB_ENV && echo "Reference bench:" $(cat git_sig) || echo "No bench found" [[ -n "$benchref" ]] && echo "benchref=$benchref" >> $GITHUB_ENV && echo "Reference bench: $benchref" || echo "No bench found"
- name: Check compiler - name: Check compiler
run: | run: |