kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-04-30 08:43:09 +00:00
Code Issues Releases Wiki Activity

Clarify stats range

Browse source 
Current update formula ensures that the
possible value range is [-32 * D, 32 * D].

So we never overflow if abs(32 * D) < INT16_MAX

Thanks to Joost and mstembera to clarify this.

No functional change.
This commit is contained in:
Marco Costalba 2017-08-18 02:02:35 -07:00
parent 01d97521fd
commit 9c35b9365d
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/movepick.h
View file

@ -38,12 +38,8 @@ struct StatBoards : public std::array<std::array<T, Size2>, Size1> {
void update(T& entry, int bonus, const int D) {
assert([&]{
int v = entry + bonus * 32 - entry * abs(bonus) / D;
return INT16_MIN < v && v < INT16_MAX;
}());
assert(abs(bonus) <= D); // Consistency check for below formula
assert(abs(bonus) <= D); // Ensure range is [-32 * D, 32 * D]
assert(abs(32 * D) < INT16_MAX); // Ensure we don't overflow
entry += bonus * 32 - entry * abs(bonus) / D;