mirror of
https://github.com/sockspls/badfish
synced 2025-04-30 16:53:09 +00:00
Remove template W param
Different W template parameters for the different statEntries are not needed, simplify by consistently using 32. Passed STC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 21683 W: 4545 L: 4424 D: 12714 http://tests.stockfishchess.org/tests/view/5ad797550ebc595700526e59 Passed LTC: LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 110391 W: 16551 L: 16562 D: 77278 http://tests.stockfishchess.org/tests/view/5ad7a88f0ebc595700526e61 Closes https://github.com/official-stockfish/Stockfish/pull/1557 Bench: 5120532
This commit is contained in:
parent
82f7d507ea
commit
a64d524d02
3 changed files with 23 additions and 23 deletions
|
@ -111,7 +111,7 @@ void MovePicker::score() {
|
||||||
for (auto& m : *this)
|
for (auto& m : *this)
|
||||||
if (Type == CAPTURES)
|
if (Type == CAPTURES)
|
||||||
m.value = PieceValue[MG][pos.piece_on(to_sq(m))]
|
m.value = PieceValue[MG][pos.piece_on(to_sq(m))]
|
||||||
+ (*captureHistory)[pos.moved_piece(m)][to_sq(m)][type_of(pos.piece_on(to_sq(m)))];
|
+ (*captureHistory)[pos.moved_piece(m)][to_sq(m)][type_of(pos.piece_on(to_sq(m)))] / 16;
|
||||||
|
|
||||||
else if (Type == QUIETS)
|
else if (Type == QUIETS)
|
||||||
m.value = (*mainHistory)[pos.side_to_move()][from_to(m)]
|
m.value = (*mainHistory)[pos.side_to_move()][from_to(m)]
|
||||||
|
|
|
@ -33,7 +33,7 @@
|
||||||
/// be a move or even a nested history. We use a class instead of naked value
|
/// be a move or even a nested history. We use a class instead of naked value
|
||||||
/// to directly call history update operator<<() on the entry so to use stats
|
/// to directly call history update operator<<() on the entry so to use stats
|
||||||
/// tables at caller sites as simple multi-dim arrays.
|
/// tables at caller sites as simple multi-dim arrays.
|
||||||
template<typename T, int W, int D>
|
template<typename T, int D>
|
||||||
class StatsEntry {
|
class StatsEntry {
|
||||||
|
|
||||||
static const bool IsInt = std::is_integral<T>::value;
|
static const bool IsInt = std::is_integral<T>::value;
|
||||||
|
@ -47,23 +47,22 @@ public:
|
||||||
operator TT() const { return entry; }
|
operator TT() const { return entry; }
|
||||||
|
|
||||||
void operator<<(int bonus) {
|
void operator<<(int bonus) {
|
||||||
|
assert(abs(bonus) <= D); // Ensure range is [-D, D]
|
||||||
|
assert(D < std::numeric_limits<T>::max()); // Ensure we don't overflow
|
||||||
|
|
||||||
assert(abs(bonus) <= D); // Ensure range is [-W * D, W * D]
|
entry += bonus - entry * abs(bonus) / D;
|
||||||
assert(W * D < std::numeric_limits<T>::max()); // Ensure we don't overflow
|
|
||||||
|
|
||||||
entry += bonus * W - entry * abs(bonus) / D;
|
assert(abs(entry) <= D);
|
||||||
|
|
||||||
assert(abs(entry) <= W * D);
|
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
/// Stats is a generic N-dimensional array used to store various statistics.
|
/// Stats is a generic N-dimensional array used to store various statistics.
|
||||||
/// The first template T parameter is the base type of the array, the W parameter
|
/// The first template parameter T is the base type of the array, the second
|
||||||
/// is the weight applied to the bonuses when we update values with the << operator,
|
/// template parameter D limits the range of updates in [-D, D] when we update
|
||||||
/// the D parameter limits the range of updates (range is [-W * D, W * D]), and
|
/// values with the << operator, while the last parameters (Size and Sizes)
|
||||||
/// the last parameters (Size and Sizes) encode the dimensions of the array.
|
/// encode the dimensions of the array.
|
||||||
template <typename T, int W, int D, int Size, int... Sizes>
|
template <typename T, int D, int Size, int... Sizes>
|
||||||
struct Stats : public std::array<Stats<T, W, D, Sizes...>, Size>
|
struct Stats : public std::array<Stats<T, D, Sizes...>, Size>
|
||||||
{
|
{
|
||||||
T* get() { return this->at(0).get(); }
|
T* get() { return this->at(0).get(); }
|
||||||
|
|
||||||
|
@ -73,34 +72,35 @@ struct Stats : public std::array<Stats<T, W, D, Sizes...>, Size>
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
template <typename T, int W, int D, int Size>
|
template <typename T, int D, int Size>
|
||||||
struct Stats<T, W, D, Size> : public std::array<StatsEntry<T, W, D>, Size> {
|
struct Stats<T, D, Size> : public std::array<StatsEntry<T, D>, Size> {
|
||||||
T* get() { return this->at(0).get(); }
|
T* get() { return this->at(0).get(); }
|
||||||
};
|
};
|
||||||
|
|
||||||
/// Different tables use different W/D parameter, name them to ease readibility
|
/// In stats table, D=0 means that the template parameter is not used
|
||||||
enum StatsParams { W2 = 2, W32 = 32, D324 = 324, D936 = 936, NOT_USED = 0 };
|
enum StatsParams { NOT_USED = 0 };
|
||||||
|
|
||||||
|
|
||||||
/// ButterflyHistory records how often quiet moves have been successful or
|
/// ButterflyHistory records how often quiet moves have been successful or
|
||||||
/// unsuccessful during the current search, and is used for reduction and move
|
/// unsuccessful during the current search, and is used for reduction and move
|
||||||
/// ordering decisions. It uses 2 tables (one for each color) indexed by
|
/// ordering decisions. It uses 2 tables (one for each color) indexed by
|
||||||
/// the move's from and to squares, see chessprogramming.wikispaces.com/Butterfly+Boards
|
/// the move's from and to squares, see chessprogramming.wikispaces.com/Butterfly+Boards
|
||||||
typedef Stats<int16_t, W32, D324, COLOR_NB, int(SQUARE_NB) * int(SQUARE_NB)> ButterflyHistory;
|
typedef Stats<int16_t, 10368, COLOR_NB, int(SQUARE_NB) * int(SQUARE_NB)> ButterflyHistory;
|
||||||
|
|
||||||
/// CounterMoveHistory stores counter moves indexed by [piece][to] of the previous
|
/// CounterMoveHistory stores counter moves indexed by [piece][to] of the previous
|
||||||
/// move, see chessprogramming.wikispaces.com/Countermove+Heuristic
|
/// move, see chessprogramming.wikispaces.com/Countermove+Heuristic
|
||||||
typedef Stats<Move, NOT_USED, NOT_USED, PIECE_NB, SQUARE_NB> CounterMoveHistory;
|
typedef Stats<Move, NOT_USED, PIECE_NB, SQUARE_NB> CounterMoveHistory;
|
||||||
|
|
||||||
/// CapturePieceToHistory is addressed by a move's [piece][to][captured piece type]
|
/// CapturePieceToHistory is addressed by a move's [piece][to][captured piece type]
|
||||||
typedef Stats<int16_t, W2, D324, PIECE_NB, SQUARE_NB, PIECE_TYPE_NB> CapturePieceToHistory;
|
typedef Stats<int16_t, 10368, PIECE_NB, SQUARE_NB, PIECE_TYPE_NB> CapturePieceToHistory;
|
||||||
|
|
||||||
/// PieceToHistory is like ButterflyHistory but is addressed by a move's [piece][to]
|
/// PieceToHistory is like ButterflyHistory but is addressed by a move's [piece][to]
|
||||||
typedef Stats<int16_t, W32, D936, PIECE_NB, SQUARE_NB> PieceToHistory;
|
typedef Stats<int16_t, 29952, PIECE_NB, SQUARE_NB> PieceToHistory;
|
||||||
|
|
||||||
/// ContinuationHistory is the combined history of a given pair of moves, usually
|
/// ContinuationHistory is the combined history of a given pair of moves, usually
|
||||||
/// the current one given a previous one. The nested history table is based on
|
/// the current one given a previous one. The nested history table is based on
|
||||||
/// PieceToHistory instead of ButterflyBoards.
|
/// PieceToHistory instead of ButterflyBoards.
|
||||||
typedef Stats<PieceToHistory, W32, NOT_USED, PIECE_NB, SQUARE_NB> ContinuationHistory;
|
typedef Stats<PieceToHistory, NOT_USED, PIECE_NB, SQUARE_NB> ContinuationHistory;
|
||||||
|
|
||||||
|
|
||||||
/// MovePicker class is used to pick one pseudo legal move at a time from the
|
/// MovePicker class is used to pick one pseudo legal move at a time from the
|
||||||
|
|
|
@ -92,7 +92,7 @@ namespace {
|
||||||
// History and stats update bonus, based on depth
|
// History and stats update bonus, based on depth
|
||||||
int stat_bonus(Depth depth) {
|
int stat_bonus(Depth depth) {
|
||||||
int d = depth / ONE_PLY;
|
int d = depth / ONE_PLY;
|
||||||
return d > 17 ? 0 : d * d + 2 * d - 2;
|
return d > 17 ? 0 : 32 * d * d + 64 * d - 64;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Skill structure is used to implement strength limit
|
// Skill structure is used to implement strength limit
|
||||||
|
|
Loading…
Add table
Reference in a new issue