mirror of
https://github.com/sockspls/badfish
synced 2025-04-29 16:23:09 +00:00
Move OnChange callback in Option ctors
Parameter 'f' is passed by value and only copied once. Moving it to avoid unnecessary copies. closes https://github.com/official-stockfish/Stockfish/pull/5014 No functional change
This commit is contained in:
parent
37bd1e774e
commit
c17ec9524d
2 changed files with 6 additions and 5 deletions
1
AUTHORS
1
AUTHORS
|
@ -12,6 +12,7 @@ Hisayori Noda (nodchip)
|
|||
# All other authors of Stockfish code (in alphabetical order)
|
||||
Aditya (absimaldata)
|
||||
Adrian Petrescu (apetresc)
|
||||
Ahmed Kerimov (wcdbmv)
|
||||
Ajith Chandy Jose (ajithcj)
|
||||
Alain Savard (Rocky640)
|
||||
Alayan Feh (Alayan-stk-2)
|
||||
|
|
|
@ -68,7 +68,7 @@ Option::Option(const char* v, OnChange f) :
|
|||
type("string"),
|
||||
min(0),
|
||||
max(0),
|
||||
on_change(f) {
|
||||
on_change(std::move(f)) {
|
||||
defaultValue = currentValue = v;
|
||||
}
|
||||
|
||||
|
@ -76,7 +76,7 @@ Option::Option(bool v, OnChange f) :
|
|||
type("check"),
|
||||
min(0),
|
||||
max(0),
|
||||
on_change(f) {
|
||||
on_change(std::move(f)) {
|
||||
defaultValue = currentValue = (v ? "true" : "false");
|
||||
}
|
||||
|
||||
|
@ -84,13 +84,13 @@ Option::Option(OnChange f) :
|
|||
type("button"),
|
||||
min(0),
|
||||
max(0),
|
||||
on_change(f) {}
|
||||
on_change(std::move(f)) {}
|
||||
|
||||
Option::Option(double v, int minv, int maxv, OnChange f) :
|
||||
type("spin"),
|
||||
min(minv),
|
||||
max(maxv),
|
||||
on_change(f) {
|
||||
on_change(std::move(f)) {
|
||||
defaultValue = currentValue = std::to_string(v);
|
||||
}
|
||||
|
||||
|
@ -98,7 +98,7 @@ Option::Option(const char* v, const char* cur, OnChange f) :
|
|||
type("combo"),
|
||||
min(0),
|
||||
max(0),
|
||||
on_change(f) {
|
||||
on_change(std::move(f)) {
|
||||
defaultValue = v;
|
||||
currentValue = cur;
|
||||
}
|
||||
|
|
Loading…
Add table
Reference in a new issue