kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-04-30 00:33:09 +00:00
Code Issues Releases Wiki Activity

Enable sleeping of available threads

Browse source 
This simple patch has devastating consequences ;-)

Now an available thread goes to sleep and is waked up after
being allocated.

This patch allows Stockfish to dramatically increase performances
on HyperThreading systems.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba 2010-10-17 11:23:59 +01:00
parent 8fdc635255
commit c59efc53c9
1 changed files with 22 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/search.cpp
View file

@ -95,7 +95,7 @@ namespace {
int ActiveThreads; int ActiveThreads;
volatile bool AllThreadsShouldExit; volatile bool AllThreadsShouldExit;
Thread threads[MAX_THREADS]; Thread threads[MAX_THREADS];
Lock MPLock, WaitLock; Lock MPLock;
WaitCondition WaitCond[MAX_THREADS]; WaitCondition WaitCond[MAX_THREADS];
}; };
@ -2224,7 +2224,9 @@ split_point_start: // At split points actual search starts from here
// If we are not thinking, wait for a condition to be signaled // If we are not thinking, wait for a condition to be signaled
// instead of wasting CPU time polling for work. // instead of wasting CPU time polling for work.
while (threadID >= ActiveThreads || threads[threadID].state == THREAD_INITIALIZING) while ( threadID >= ActiveThreads
|| threads[threadID].state == THREAD_INITIALIZING
|| (!sp && threads[threadID].state == THREAD_AVAILABLE))
{ {
assert(!sp); assert(!sp);
assert(threadID != 0); assert(threadID != 0);
@ -2232,14 +2234,21 @@ split_point_start: // At split points actual search starts from here
if (AllThreadsShouldExit) if (AllThreadsShouldExit)
break; break;
lock_grab(&MPLock);
// Retest condition under lock protection
if (!( threadID >= ActiveThreads
|| threads[threadID].state == THREAD_INITIALIZING
|| (!sp && threads[threadID].state == THREAD_AVAILABLE)))
{
lock_release(&MPLock);
continue;
}
// Put thread to sleep
threads[threadID].state = THREAD_AVAILABLE; threads[threadID].state = THREAD_AVAILABLE;
cond_wait(&WaitCond[threadID], &MPLock);
lock_grab(&WaitLock); lock_release(&MPLock);
if (threadID >= ActiveThreads || threads[threadID].state == THREAD_INITIALIZING)
cond_wait(&WaitCond[threadID], &WaitLock);
lock_release(&WaitLock);
} }
// If this thread has been assigned work, launch a search // If this thread has been assigned work, launch a search
@ -2299,7 +2308,6 @@ split_point_start: // At split points actual search starts from here
// Initialize global locks // Initialize global locks
lock_init(&MPLock); lock_init(&MPLock);
lock_init(&WaitLock);
for (i = 0; i < MAX_THREADS; i++) for (i = 0; i < MAX_THREADS; i++)
cond_init(&WaitCond[i]); cond_init(&WaitCond[i]);
@ -2362,7 +2370,6 @@ split_point_start: // At split points actual search starts from here
for (int j = 0; j < MAX_ACTIVE_SPLIT_POINTS; j++) for (int j = 0; j < MAX_ACTIVE_SPLIT_POINTS; j++)
lock_destroy(&(threads[i].splitPoints[j].lock)); lock_destroy(&(threads[i].splitPoints[j].lock));
lock_destroy(&WaitLock);
lock_destroy(&MPLock); lock_destroy(&MPLock);
// Now we can safely destroy the wait conditions // Now we can safely destroy the wait conditions
@ -2528,6 +2535,8 @@ split_point_start: // At split points actual search starts from here
assert(i == master || threads[i].state == THREAD_BOOKED); assert(i == master || threads[i].state == THREAD_BOOKED);
threads[i].state = THREAD_WORKISWAITING; // This makes the slave to exit from idle_loop() threads[i].state = THREAD_WORKISWAITING; // This makes the slave to exit from idle_loop()
if (i != master)
wake_sleeping_thread(i);
} }
// Everything is set up. The master thread enters the idle loop, from // Everything is set up. The master thread enters the idle loop, from
@ -2555,9 +2564,9 @@ split_point_start: // At split points actual search starts from here
void ThreadsManager::wake_sleeping_thread(int threadID) { void ThreadsManager::wake_sleeping_thread(int threadID) {
lock_grab(&WaitLock); lock_grab(&MPLock);
cond_signal(&WaitCond[threadID]); cond_signal(&WaitCond[threadID]);
lock_release(&WaitLock); lock_release(&MPLock);
} }