kate/BadFish
1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-07-11 19:49:14 +00:00
Code Issues Releases Wiki Activity

Improve previous patch

Browse source 
Only in case of promotion we care about an upper case
promotion piece char, so std::transform() is overkill
for the task.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba 2012-05-12 09:21:52 +01:00
parent 1b2af05ea6
commit ecb84464f9
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/misc.h
View file

@ -38,7 +38,7 @@ extern void dbg_mean_of(int v);
extern void dbg_print(); extern void dbg_print();
class Position; class Position;
extern Move move_from_uci(const Position& pos, std::string str); extern Move move_from_uci(const Position& pos, std::string& str);
extern const std::string move_to_uci(Move m, bool chess960); extern const std::string move_to_uci(Move m, bool chess960);
extern const std::string move_to_san(Position& pos, Move m); extern const std::string move_to_san(Position& pos, Move m);

7
src/move.cpp
View file

@ -17,7 +17,6 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
#include <algorithm>
#include <cassert> #include <cassert>
#include <string> #include <string>
@ -57,10 +56,10 @@ const string move_to_uci(Move m, bool chess960) {
/// simple coordinate notation and returns an equivalent Move if any. /// simple coordinate notation and returns an equivalent Move if any.
/// Moves are guaranteed to be legal. /// Moves are guaranteed to be legal.
Move move_from_uci(const Position& pos, string str) { Move move_from_uci(const Position& pos, string& str) {
// Some GUIs, like Junior, could send promotion in uppercase if (str.length() == 5) // Junior could send promotion in uppercase
std::transform(str.begin(), str.end(), str.begin(), tolower); str[4] = char(tolower(str[4]));
for (MoveList<MV_LEGAL> ml(pos); !ml.end(); ++ml) for (MoveList<MV_LEGAL> ml(pos); !ml.end(); ++ml)
if (str == move_to_uci(ml.move(), pos.is_chess960())) if (str == move_to_uci(ml.move(), pos.is_chess960()))