mirror of
https://github.com/sockspls/badfish
synced 2025-07-12 03:59:15 +00:00

since the introduction of NNUE (first released with Stockfish 12), we have maintained the classical evaluation as part of SF in frozen form. The idea that this code could lead to further inputs to the NN or search did not materialize. Now, after five releases, this PR removes the classical evaluation from SF. Even though this evaluation is probably the best of its class, it has become unimportant for the engine's strength, and there is little need to maintain this code (roughly 25% of SF) going forward, or to expend resources on trying to improve its integration in the NNUE eval. Indeed, it had still a very limited use in the current SF, namely for the evaluation of positions that are nearly decided based on material difference, where the speed of the classical evaluation outweights its inaccuracies. This impact on strength is small, roughly 2Elo, and probably decreasing in importance as the TC grows. Potentially, removal of this code could lead to the development of techniques to have faster, but less accurate NN evaluation, for certain positions. STC https://tests.stockfishchess.org/tests/view/64a320173ee09aa549c52157 Elo: -2.35 ± 1.1 (95%) LOS: 0.0% Total: 100000 W: 24916 L: 25592 D: 49492 Ptnml(0-2): 287, 12123, 25841, 11477, 272 nElo: -4.62 ± 2.2 (95%) PairsRatio: 0.95 LTC https://tests.stockfishchess.org/tests/view/64a320293ee09aa549c5215b Elo: -1.74 ± 1.0 (95%) LOS: 0.0% Total: 100000 W: 25010 L: 25512 D: 49478 Ptnml(0-2): 44, 11069, 28270, 10579, 38 nElo: -3.72 ± 2.2 (95%) PairsRatio: 0.96 VLTC SMP https://tests.stockfishchess.org/tests/view/64a3207c3ee09aa549c52168 Elo: -1.70 ± 0.9 (95%) LOS: 0.0% Total: 100000 W: 25673 L: 26162 D: 48165 Ptnml(0-2): 8, 9455, 31569, 8954, 14 nElo: -3.95 ± 2.2 (95%) PairsRatio: 0.95 closes https://github.com/official-stockfish/Stockfish/pull/4674 Bench: 1444646
192 lines
6.1 KiB
C++
192 lines
6.1 KiB
C++
/*
|
|
Stockfish, a UCI chess playing engine derived from Glaurung 2.1
|
|
Copyright (C) 2004-2023 The Stockfish developers (see AUTHORS file)
|
|
|
|
Stockfish is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
Stockfish is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <algorithm>
|
|
#include <cassert>
|
|
#include <ostream>
|
|
#include <sstream>
|
|
|
|
#include "evaluate.h"
|
|
#include "misc.h"
|
|
#include "search.h"
|
|
#include "thread.h"
|
|
#include "tt.h"
|
|
#include "uci.h"
|
|
#include "syzygy/tbprobe.h"
|
|
|
|
using std::string;
|
|
|
|
namespace Stockfish {
|
|
|
|
UCI::OptionsMap Options; // Global object
|
|
|
|
namespace UCI {
|
|
|
|
/// 'On change' actions, triggered by an option's value change
|
|
static void on_clear_hash(const Option&) { Search::clear(); }
|
|
static void on_hash_size(const Option& o) { TT.resize(size_t(o)); }
|
|
static void on_logger(const Option& o) { start_logger(o); }
|
|
static void on_threads(const Option& o) { Threads.set(size_t(o)); }
|
|
static void on_tb_path(const Option& o) { Tablebases::init(o); }
|
|
static void on_eval_file(const Option&) { Eval::NNUE::init(); }
|
|
|
|
/// Our case insensitive less() function as required by UCI protocol
|
|
bool CaseInsensitiveLess::operator() (const string& s1, const string& s2) const {
|
|
|
|
return std::lexicographical_compare(s1.begin(), s1.end(), s2.begin(), s2.end(),
|
|
[](char c1, char c2) { return tolower(c1) < tolower(c2); });
|
|
}
|
|
|
|
|
|
/// UCI::init() initializes the UCI options to their hard-coded default values
|
|
|
|
void init(OptionsMap& o) {
|
|
|
|
constexpr int MaxHashMB = Is64Bit ? 33554432 : 2048;
|
|
|
|
o["Debug Log File"] << Option("", on_logger);
|
|
o["Threads"] << Option(1, 1, 1024, on_threads);
|
|
o["Hash"] << Option(16, 1, MaxHashMB, on_hash_size);
|
|
o["Clear Hash"] << Option(on_clear_hash);
|
|
o["Ponder"] << Option(false);
|
|
o["MultiPV"] << Option(1, 1, 500);
|
|
o["Skill Level"] << Option(20, 0, 20);
|
|
o["Move Overhead"] << Option(10, 0, 5000);
|
|
o["Slow Mover"] << Option(100, 10, 1000);
|
|
o["nodestime"] << Option(0, 0, 10000);
|
|
o["UCI_Chess960"] << Option(false);
|
|
o["UCI_AnalyseMode"] << Option(false);
|
|
o["UCI_LimitStrength"] << Option(false);
|
|
o["UCI_Elo"] << Option(1320, 1320, 3190);
|
|
o["UCI_ShowWDL"] << Option(false);
|
|
o["SyzygyPath"] << Option("<empty>", on_tb_path);
|
|
o["SyzygyProbeDepth"] << Option(1, 1, 100);
|
|
o["Syzygy50MoveRule"] << Option(true);
|
|
o["SyzygyProbeLimit"] << Option(7, 0, 7);
|
|
o["EvalFile"] << Option(EvalFileDefaultName, on_eval_file);
|
|
}
|
|
|
|
|
|
/// operator<<() is used to print all the options default values in chronological
|
|
/// insertion order (the idx field) and in the format defined by the UCI protocol.
|
|
|
|
std::ostream& operator<<(std::ostream& os, const OptionsMap& om) {
|
|
|
|
for (size_t idx = 0; idx < om.size(); ++idx)
|
|
for (const auto& it : om)
|
|
if (it.second.idx == idx)
|
|
{
|
|
const Option& o = it.second;
|
|
os << "\noption name " << it.first << " type " << o.type;
|
|
|
|
if (o.type == "string" || o.type == "check" || o.type == "combo")
|
|
os << " default " << o.defaultValue;
|
|
|
|
if (o.type == "spin")
|
|
os << " default " << int(stof(o.defaultValue))
|
|
<< " min " << o.min
|
|
<< " max " << o.max;
|
|
|
|
break;
|
|
}
|
|
|
|
return os;
|
|
}
|
|
|
|
|
|
/// Option class constructors and conversion operators
|
|
|
|
Option::Option(const char* v, OnChange f) : type("string"), min(0), max(0), on_change(f)
|
|
{ defaultValue = currentValue = v; }
|
|
|
|
Option::Option(bool v, OnChange f) : type("check"), min(0), max(0), on_change(f)
|
|
{ defaultValue = currentValue = (v ? "true" : "false"); }
|
|
|
|
Option::Option(OnChange f) : type("button"), min(0), max(0), on_change(f)
|
|
{}
|
|
|
|
Option::Option(double v, int minv, int maxv, OnChange f) : type("spin"), min(minv), max(maxv), on_change(f)
|
|
{ defaultValue = currentValue = std::to_string(v); }
|
|
|
|
Option::Option(const char* v, const char* cur, OnChange f) : type("combo"), min(0), max(0), on_change(f)
|
|
{ defaultValue = v; currentValue = cur; }
|
|
|
|
Option::operator int() const {
|
|
assert(type == "check" || type == "spin");
|
|
return (type == "spin" ? std::stoi(currentValue) : currentValue == "true");
|
|
}
|
|
|
|
Option::operator std::string() const {
|
|
assert(type == "string");
|
|
return currentValue;
|
|
}
|
|
|
|
bool Option::operator==(const char* s) const {
|
|
assert(type == "combo");
|
|
return !CaseInsensitiveLess()(currentValue, s)
|
|
&& !CaseInsensitiveLess()(s, currentValue);
|
|
}
|
|
|
|
|
|
/// operator<<() inits options and assigns idx in the correct printing order
|
|
|
|
void Option::operator<<(const Option& o) {
|
|
|
|
static size_t insert_order = 0;
|
|
|
|
*this = o;
|
|
idx = insert_order++;
|
|
}
|
|
|
|
|
|
/// operator=() updates currentValue and triggers on_change() action. It's up to
|
|
/// the GUI to check for option's limits, but we could receive the new value
|
|
/// from the user by console window, so let's check the bounds anyway.
|
|
|
|
Option& Option::operator=(const string& v) {
|
|
|
|
assert(!type.empty());
|
|
|
|
if ( (type != "button" && type != "string" && v.empty())
|
|
|| (type == "check" && v != "true" && v != "false")
|
|
|| (type == "spin" && (stof(v) < min || stof(v) > max)))
|
|
return *this;
|
|
|
|
if (type == "combo")
|
|
{
|
|
OptionsMap comboMap; // To have case insensitive compare
|
|
string token;
|
|
std::istringstream ss(defaultValue);
|
|
while (ss >> token)
|
|
comboMap[token] << Option();
|
|
if (!comboMap.count(v) || v == "var")
|
|
return *this;
|
|
}
|
|
|
|
if (type != "button")
|
|
currentValue = v;
|
|
|
|
if (on_change)
|
|
on_change(*this);
|
|
|
|
return *this;
|
|
}
|
|
|
|
} // namespace UCI
|
|
|
|
} // namespace Stockfish
|