mirror of
https://github.com/sockspls/badfish
synced 2025-05-01 17:19:36 +00:00
952740b36c
The commit adds a CI workflow that uses the included-what-you-use (IWYU) tool to check for missing or superfluous includes in .cpp files and their corresponding .h files. This means that some .h files (especially in the nnue folder) are not checked yet. The CI setup looks like this: - We build IWYU from source to include some yet unreleased fixes. This IWYU version targets LLVM 17. Thus, we get the latest release candidate of LLVM 17 from LLVM's nightly packages. - The Makefile now has an analyze target that just build the object files (without linking) - The CI uses the analyze target with the IWYU tool as compiler to analyze the compiled .cpp file and its corresponding .h file. - If IWYU suggests a change the build fails (-Xiwyu --error). - To avoid false positives we use LLVM's libc++ as standard library - We have a custom mappings file that adds some mappings that are missing in IWYU's default mappings We also had to add one IWYU pragma to prevent a false positive in movegen.h. https://github.com/official-stockfish/Stockfish/pull/4783 No functional change
47 lines
1.5 KiB
YAML
47 lines
1.5 KiB
YAML
name: Stockfish
|
|
on:
|
|
workflow_call:
|
|
jobs:
|
|
Analyzers:
|
|
name: Check includes
|
|
runs-on: ubuntu-22.04
|
|
defaults:
|
|
run:
|
|
working-directory: Stockfish/src
|
|
shell: bash
|
|
steps:
|
|
- name: Checkout Stockfish
|
|
uses: actions/checkout@v3
|
|
with:
|
|
path: Stockfish
|
|
|
|
- name: Checkout include-what-you-use
|
|
uses: actions/checkout@v3
|
|
with:
|
|
repository: include-what-you-use/include-what-you-use
|
|
ref: f25caa280dc3277c4086ec345ad279a2463fea0f
|
|
path: include-what-you-use
|
|
|
|
- name: Download required linux packages
|
|
run: |
|
|
sudo add-apt-repository 'deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main'
|
|
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
|
|
sudo apt update
|
|
sudo apt install -y libclang-17-dev clang-17 libc++-17-dev
|
|
|
|
- name: Set up include-what-you-use
|
|
run: |
|
|
mkdir build && cd build
|
|
cmake -G "Unix Makefiles" -DCMAKE_PREFIX_PATH="/usr/lib/llvm-17" ..
|
|
sudo make install
|
|
working-directory: include-what-you-use
|
|
|
|
- name: Check include-what-you-use
|
|
run: include-what-you-use --version
|
|
|
|
- name: Check includes
|
|
run: >
|
|
make analyze
|
|
COMP=clang
|
|
CXX=include-what-you-use
|
|
CXXFLAGS="-stdlib=libc++ -Xiwyu --comment_style=long -Xiwyu --mapping='${{ github.workspace }}/Stockfish/.github/workflows/libcxx17.imp' -Xiwyu --error"
|