1
0
Fork 0
mirror of https://github.com/sockspls/badfish synced 2025-05-02 01:29:36 +00:00
BadFish/src
Joost VandeVondele 59f1d0c7dd Fix progress issue with shuffling extensions
Fixes issues #2126 and #2189 where no progress in rootDepth is made for particular fens:

8/8/3P3k/8/1p6/8/1P6/1K3n2 b - - 0 1
8/1r1rp1k1/1b1pPp2/2pP1Pp1/1pP3Pp/pP5P/P5K1/8 w - - 79 46

the cause are the shuffle extensions. Upon closer analysis, it appears that in these cases a shuffle extension is made for every node searched, and progess can not be made. This patch implements a fix, namely to limit the number of extensions relative to the number of nodes searched. The ratio employed is 1/4, which fixes the issues seen so far, but it is a heuristic, and I expect that certain positions might require an even smaller fraction.

The patch was tested as a bug fix and passed:

STC:
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 56601 W: 12633 L: 12581 D: 31387
http://tests.stockfishchess.org/tests/view/5d02b37a0ebc5925cf09f6da

LTC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 52042 W: 8907 L: 8837 D: 34298
http://tests.stockfishchess.org/tests/view/5d0319420ebc5925cf09fe57

Furthermore, to confirm that the shuffle extension in this form indeed still brings Elo, one more test at VLTC was performed:
VLTC:
LLR: 2.96 (-2.94,2.94) [0.00,3.50]
Total: 142022 W: 20963 L: 20435 D: 100624
http://tests.stockfishchess.org/tests/view/5d03630d0ebc5925cf0a011a

Bench: 3961247
2019-06-20 16:15:57 +02:00
..
syzygy Increase thread stack for OS X (#2035) 2019-03-12 08:35:10 +01:00
benchmark.cpp Stockfish 10-beta 2018-11-19 11:18:21 +01:00
bitbase.cpp Assorted trivial cleanups 4/2019 2019-05-02 19:30:26 +02:00
bitboard.cpp Assorted trivial cleanups 4/2019 2019-05-02 19:30:26 +02:00
bitboard.h Remove backmost_sq (#2190) 2019-06-14 08:22:02 +02:00
endgame.cpp Remove backmost_sq (#2190) 2019-06-14 08:22:02 +02:00
endgame.h Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
evaluate.cpp Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
evaluate.h A combo of parameter tweaks 2018-12-13 13:35:35 +01:00
main.cpp Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
Makefile Allow for address sanitizer. (#2119) 2019-04-27 20:47:06 +02:00
material.cpp Remove per thread instances of Endgames. (#2056) 2019-05-15 10:41:58 +02:00
material.h Changes identified in RENAME/REFORMATTING thread (#1861) 2018-12-11 13:47:56 +01:00
misc.cpp Assorted trivial cleanups 4/2019 2019-05-02 19:30:26 +02:00
misc.h Assorted trivial cleanups 4/2019 2019-05-02 19:30:26 +02:00
movegen.cpp Assorted trivial cleanups 2/2019 2019-03-05 11:13:02 +01:00
movegen.h Stockfish 10-beta 2018-11-19 11:18:21 +01:00
movepick.cpp Remove Movepick::move (#2085) 2019-04-17 21:13:39 +02:00
movepick.h Remove Movepick::move (#2085) 2019-04-17 21:13:39 +02:00
pawns.cpp Remove backmost_sq (#2190) 2019-06-14 08:22:02 +02:00
pawns.h Increase pawns cache (#2187) 2019-06-14 07:36:42 +02:00
position.cpp Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
position.h Simplify semiopen_file (#2165) 2019-05-29 10:00:32 +02:00
psqt.cpp Assorted trivial cleanups 1/2019 2019-02-08 10:20:43 +01:00
search.cpp Fix progress issue with shuffling extensions 2019-06-20 16:15:57 +02:00
search.h Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
thread.cpp Fix progress issue with shuffling extensions 2019-06-20 16:15:57 +02:00
thread.h Fix progress issue with shuffling extensions 2019-06-20 16:15:57 +02:00
thread_win32_osx.h Increase thread stack for OS X (#2035) 2019-03-12 08:35:10 +01:00
timeman.cpp Assorted trivial cleanups 4/2019 2019-05-02 19:30:26 +02:00
timeman.h Stockfish 10-beta 2018-11-19 11:18:21 +01:00
tt.cpp Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
tt.h Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
types.h Assorted trivial cleanups 5/2019 2019-06-09 14:57:08 +02:00
uci.cpp Simplify pondering time management (#1899) 2019-01-20 19:14:24 +01:00
uci.h Stockfish 10-beta 2018-11-19 11:18:21 +01:00
ucioption.cpp Assorted trivial cleanups 4/2019 2019-05-02 19:30:26 +02:00