mirror of
https://github.com/sockspls/badfish
synced 2025-04-30 08:43:09 +00:00
a4fedd8152
This patch is a simplification and a fix to dealing with null moves scores that returns proven mates or TB scores by preventing 'null move pruning' if the nullvalue is in that range. Current solution downgrades nullValues on the non-PV node but the value can be used in a transposed PV-node to the same position afterwards (Triangulation), the later is prone to propagate a wrong score (96.05) to root that will not be refuted unless we search further. Score of (96.05) can be obtained be two methods, maxim static-eval returned on Pv update (mostly qSearch) this downgrade (clamp) in NMP and theoretically can happen with or without TBs but the second scenario is more dangerous than the first. This fixes the reproducible case in very common scenarios with TBs as shown in the debugging at discord. Fixes: #4699 Passed STC: https://tests.stockfishchess.org/tests/view/64c1eca8dc56e1650abba6f9 LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 670048 W: 171132 L: 171600 D: 327316 Ptnml(0-2): 2134, 75687, 179820, 75279, 2104 Passed LTC: https://tests.stockfishchess.org/tests/view/64c5e130dc56e1650abc0438 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 92868 W: 23642 L: 23499 D: 45727 Ptnml(0-2): 52, 9509, 27171, 9648, 54 closes https://github.com/official-stockfish/Stockfish/pull/4715 Bench: 1327410 |
||
|---|---|---|
| .. | ||
| incbin | ||
| nnue | ||
| syzygy | ||
| benchmark.cpp | ||
| benchmark.h | ||
| bitboard.cpp | ||
| bitboard.h | ||
| evaluate.cpp | ||
| evaluate.h | ||
| main.cpp | ||
| Makefile | ||
| misc.cpp | ||
| misc.h | ||
| movegen.cpp | ||
| movegen.h | ||
| movepick.cpp | ||
| movepick.h | ||
| position.cpp | ||
| position.h | ||
| search.cpp | ||
| search.h | ||
| thread.cpp | ||
| thread.h | ||
| thread_win32_osx.h | ||
| timeman.cpp | ||
| timeman.h | ||
| tt.cpp | ||
| tt.h | ||
| tune.cpp | ||
| tune.h | ||
| types.h | ||
| uci.cpp | ||
| uci.h | ||
| ucioption.cpp | ||