mirror of
https://github.com/sockspls/badfish
synced 2025-05-01 01:03:09 +00:00
4eee603433
We want all the UCI options are printed in the order in which are assigned, so we use an index that, depending on Options.size(), increases after each option is added to the map. The problem is that, for instance, in the first assignment: o["Write Debug Log"] = Option(false, on_logger); Options.size() can value 0 or 1 according if the l-value (that increments the size) has been evaluated after or before the r-value (that uses the size value). The culprit is that assignment operator in C++ is not a sequence point: http://en.wikipedia.org/wiki/Sequence_point (Note: to be nitpick here we actually use std::map::operator=() that being a function can evaluate its arguments in any order) So there is no guarantee on what term is evaluated first and behavior is undefined by standard in this case. The net result is that in case r-value is evaluated after l-value the last idx is not size() - 1, but size() and in the printing loop we miss the last option! Bug was there since ages but only recently has been exposed by the removal of UCI_Analyze option so that the last one becomes UCI_Chess960 and when it is missing engine cannot play anymore Chess960. The fix is trivial (although a bit hacky): just increase the last loop index. Reported by Eric Mullins that found it on an ARM and MIPS platforms with gcc 4.7 No functional change. |
||
|---|---|---|
| .. | ||
| benchmark.cpp | ||
| bitbase.cpp | ||
| bitboard.cpp | ||
| bitboard.h | ||
| bitcount.h | ||
| book.cpp | ||
| book.h | ||
| endgame.cpp | ||
| endgame.h | ||
| evaluate.cpp | ||
| evaluate.h | ||
| main.cpp | ||
| Makefile | ||
| material.cpp | ||
| material.h | ||
| misc.cpp | ||
| misc.h | ||
| movegen.cpp | ||
| movegen.h | ||
| movepick.cpp | ||
| movepick.h | ||
| notation.cpp | ||
| notation.h | ||
| pawns.cpp | ||
| pawns.h | ||
| platform.h | ||
| position.cpp | ||
| position.h | ||
| psqtab.h | ||
| rkiss.h | ||
| search.cpp | ||
| search.h | ||
| thread.cpp | ||
| thread.h | ||
| timeman.cpp | ||
| timeman.h | ||
| tt.cpp | ||
| tt.h | ||
| types.h | ||
| uci.cpp | ||
| ucioption.cpp | ||
| ucioption.h | ||